Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_abandoned flag to segments #132

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add is_abandoned flag to segments #132

merged 3 commits into from
Feb 29, 2024

Conversation

brad-richardson
Copy link
Contributor

@brad-richardson brad-richardson commented Feb 26, 2024

Description

Adds road flag that allows for identification and downstream filtering of segments that are no longer maintained. These are typically denoted in OSM with abandoned*= and disused*= tags.

Reference

  1. Internal issue

Testing

Ran all tests including against added example.

Checklist

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  4. Update Docusaurus documentation, if an update is required.
  5. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation Website

Docs preview for this PR.

Copy link
Contributor

@jonahadkins jonahadkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@vcschapp vcschapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                       _____|\
                  _.--| SSt |:
                 <____|.----||
                        .---''---,
                         ;..__..'    _...
                       ,'/  ;|/..--''    \
                     ,'_/.-/':            :
                _..-'''/  /  |  \    \   _|/|
               \      /-./_ \;   \    \,;'   \
               ,\    / \:  `:\    \   //    `:`.
             ,'  \  /-._;   | :    : ::    ,.   .
           ,'     ::   /`-._| |    | || ' :  `.`.)
        _,'       |;._:: |  | |    | `|   :    `'
      ,'   `.     /   |`-:_ ; |    |  |  : \
      `--.   )   /|-._:    :          |   \ \
         /  /   :_|   ;`-._;   __..--';    : :
        /  (    ;|;-./_  _/.-:'o |   /     ' |
       /  , \._/_/_./--''/_|:|___|_,'        |
      :  /   `'-'--'----'---------'          |
      | :     O ._O   O_. O ._O   O_.      ; ;
      : `.      //    //    //    //     ,' /
    ~~~`.______//____//____//____//_______,'~
              //    //~   //    //
       ~~   _//   _//   _// ~ _//     ~
     ~     / /   / /   / /   / /  ~      ~~
          ~~~   ~~~   ~~~   ~~~

@vcschapp vcschapp merged commit 4063e6e into dev Feb 29, 2024
2 checks passed
@vcschapp vcschapp deleted the abandoned_segments branch February 29, 2024 21:53
vcschapp pushed a commit that referenced this pull request Mar 12, 2024
Add is_abandoned flag to segments

OvertureMaps/tf-transportation#85

---------

Co-authored-by: Brad Richardson <[email protected]>
jonahadkins pushed a commit that referenced this pull request Jul 12, 2024
Add is_abandoned flag to segments

OvertureMaps/tf-transportation#85

---------

Co-authored-by: Brad Richardson <[email protected]>
jonahadkins pushed a commit that referenced this pull request Sep 7, 2024
Add is_abandoned flag to segments

OvertureMaps/tf-transportation#85

---------

Co-authored-by: Brad Richardson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants